capacitor-community / sqlite

Community plugin for native & electron SQLite databases
MIT License
426 stars 104 forks source link

Create CapacitorJS v6 package compatibility #541

Open bluepuma77 opened 1 month ago

bluepuma77 commented 1 month ago

Describe the bug CapacitorJS v6.0 was just released (Github, Blog). Now npm is throwing error on update, need to use --force or --legacy-peer-deps to make it work.

To Reproduce Update all npm libraries to latest with ncu -u, then run npm i.

Expected behavior Should work without "force".

Additional context Big question for me is how to make CapacitorJS v5 continue smoothly, so those users don't get an update error.

bluepuma77 commented 1 month ago

According to ChatGPT multiple major versions can be enabled:

  "peerDependencies": {
    "@capacitor/core": "^5.0.0 || ^6.0.0"
  },
jepiqueau commented 1 month ago

@bluepuma77 capacitor 6 is not supported yet

rosostolato commented 1 month ago

@jepiqueau, any chance we can expect support for capacitor 6 in the next few days?

-- edit --

I just tried to force install the plugin on capacitor v6 and it didn't break my app. Can you please push a minor version adding support to version 6 like @bluepuma77 suggested? It will stop breaking the npm install at least.

jepiqueau commented 1 month ago

@rosostolato not really Capacitor 6 requires for iOS Xcode 15 which runs only on Sonatra which is not supported on my MacBook Pro. So i cannot build the ios part otherwise it would have been released already.

lajith111 commented 4 weeks ago

@jepiqueau time being is it possible to update only for Android ?

rosostolato commented 4 weeks ago

@jepiqueau got it, I had just tested on Android.

But actually, xcode 15 requires Ventura 13.5 to run: https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes

Doesn't your Mac support it? And if not, can't you run it on a vm? Or if you tell me what I need to do, I can build it for you.

jepiqueau commented 4 weeks ago

@rosostolato thanks for your proposalbut my Mac is from 2016so it does not even support Ventura. I will what solutions i have but it will take a bit of time free which is not the case those week as i got some personal issues. I will keep you aware of the progress

bluepuma77 commented 3 weeks ago

@jepiqueau Did you contact Ionic developer relations, if they could sponsor you a new MacBook, as you are an important community maintainer? Their "Director of Developer Relations" is on LinkedIn 😄

jepiqueau commented 3 weeks ago

@bluepuma77 can give me his références name and email please

bluepuma77 commented 3 weeks ago

Sorry, only got links: https://www.linkedin.com/in/mhartington/ https://twitter.com/mhartington https://mastodon.social/@mhartington https://github.com/mhartington

Or you could try other channels: https://forum.ionicframework.com/ https://discord.com/invite/UPYYRhtyzp

Meerkap commented 2 weeks ago

Same here, waiting for support v6

jepiqueau commented 2 weeks ago

@bluepuma77 i sent an email to Mike, we will see. May be some of you can also sponsor me for part of it

rosostolato commented 2 weeks ago

Dude, you should try a VM. If you have Linux or even windows, you can try docker-osx. It's not illegal, you can see more info on their faq section.

jepiqueau commented 2 weeks ago

@rosostolato i tried a VM with Windows but it is far to slow and the mouse motion is also slow making it really not useful.

rosostolato commented 2 weeks ago

@jepiqueau have you tried docker-osx running on wsl? I know it's not that fast like an actual Mac but not too slow that you can't use to compile stuff.

RubioN commented 2 weeks ago

Waiting for support v6 too here 🙏

rosostolato commented 2 weeks ago

@jepiqueau if you tell me the steps I can compile it for you. We can't just let this package get stale because of that.

jepiqueau commented 1 week ago

@rosostolato i have publish an alpha version for Capacitor6 that you can install with `npm i --save @capacitor-community/sqlite@capv6 in your app, i will check it to day for Android, Electron and Web by migrating my testing apps to Capacitor6. If you can do it for one of your app (migrating to Capacitor6) and build it and report to me the result it would be great

lajith111 commented 1 week ago

@jepiqueau I have checked my app in browser as well as android emulator(14) its working fine..Thanks

jepiqueau commented 1 week ago

@bluepuma77 @rosostolato @lajith111 @RubioN @Meerkap I tested the @capacitor-community/sqlite@capv6 on Android, Electron, Web it works fine.

jepiqueau commented 1 week ago

@lajith111 thanks for the feedback on Android and Web

RubioN commented 1 week ago

Thank you very much @jepiqueau ! I'll keep an eye on developments for iOS

eideard-hm commented 1 week ago

Same here, waiting for support v6 image

rosostolato commented 1 week ago

@eideard-hm you can try out the new version by installing @capacitor-community/sqlite@capv6

jepiqueau commented 1 week ago

@rosostolato did you try building the ios plugin in an app ? What was the result?

rosostolato commented 1 week ago

@jepiqueau not yet, I will try tonight or tomorrow, I will let you know.

rosostolato commented 1 week ago

@jepiqueau I just tested it on my capacitor v6 app and everything looks good. Both iOS and Android are just working. Thank you for that!

jepiqueau commented 1 week ago

@rosostolato thanks for your feedback. Happy of this

xsorifc28 commented 6 days ago

When V6?