chore: demo app import path should be relative

capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor

MIT License

185 stars 74 forks source link

chore: demo app import path should be relative #123

Closed hideokamoto closed 2 years ago

hideokamoto commented 2 years ago

The demo application does not install the @capacitor-community/stripe library. So we need to use the internal module.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for capacitor-community-stripe ready!

🔨 Explore the source changes: 423aa5c68e62150b0160c61d07c58701186ef9b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/capacitor-community-stripe/deploys/61a20eafa52655000771b2fc

😎 Browse the preview: https://deploy-preview-123--capacitor-community-stripe.netlify.app/

rdlabo commented 2 years ago

In my memory, this works fine for JS, but sometimes the native code replacement didn't work. Also, the demo should be copy-and-paste code, so I think the developer of this plugin should do npm link it at hand.

Thanks.

hideokamoto commented 2 years ago

Okay, should we close this?