capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor

MIT License

185 stars 74 forks source link

feat: can create PaymentSheet and PaymentFlow without customer id #126

Closed hideokamoto closed 2 years ago

hideokamoto commented 2 years ago

Ref: #116 The customerId prop is not required property in Stripe. So we can change this from required to optional.

Try to run (without customer id)

We can test this by the following steps.

Payment Sheet

Run npm run build
Go to demo app (demo/angular)
Run npm install
Delete these line -> https://github.com/capacitor-community/stripe/blob/feat/no-customer-id/demo/angular/src/app/tab2/tab2.page.ts#L89-L90
Run npm start
Go to http://localhost:4200/tabs/tab2
Click "Expect Happy Path"

Payment Flow

Run npm run build
Go to demo app (demo/angular)
Run npm install
Delete these line -> https://github.com/capacitor-community/stripe/blob/feat/no-customer-id/demo/angular/src/app/tab3/tab3.page.ts#L112-L113
Run npm start
Go to http://localhost:4200/tabs/tab3
Click "Expect Happy Path"

netlify[bot] commented 2 years ago

✔️ Deploy Preview for capacitor-community-stripe ready!

🔨 Explore the source changes: 9a7d5b7e5664d4e0f67b818110d6d75906ad5477

🔍 Inspect the deploy log: https://app.netlify.com/sites/capacitor-community-stripe/deploys/61a39b0ecca43b0007075a4e

😎 Browse the preview: https://deploy-preview-126--capacitor-community-stripe.netlify.app

rdlabo commented 2 years ago

Thanks for your work!!