capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor
MIT License
185 stars 74 forks source link

feat: hide zip code (web) #127

Closed hideokamoto closed 2 years ago

hideokamoto commented 2 years ago

To merge this PR, we can hide the ZIP code field from the payment sheet/flow modal.

スクリーンショット 2021-11-29 0 14 18
await Stripe.createPaymentSheet({
      paymentIntentClientSecret: paymentIntent,
      customerEphemeralKeySecret: ephemeralKey,
      customerId: customer,
      merchantDisplayName: 'rdlabo',
      zipCode: false
    })

need help

Now the update is only for the web. As we can, we want to support this for iOS/Android.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for capacitor-community-stripe ready!

🔨 Explore the source changes: 7d72dba1742b523f76cb8e27e99b628840b238ed

🔍 Inspect the deploy log: https://app.netlify.com/sites/capacitor-community-stripe/deploys/62319188f19c610009d316cb

😎 Browse the preview: https://deploy-preview-127--capacitor-community-stripe.netlify.app/

rdlabo commented 2 years ago

Thanks for your work.

I think this function is important. But we don't expect zipCode to be boolean. so key name should change to be useZipCode or someone. What do you think? @hideokamoto

hideokamoto commented 2 years ago

Which one do you prefer?

And is it possible to support this attribute for iOS and Android? @rdlabo

rdlabo commented 2 years ago

So... withZipCode will be use!

And is it possible to support this attribute for iOS and Android?

No, Stripe iOS/Android don't has API for hide of zipcode. This function will be web only.