search

capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor
https://capacitor-community-stripe.netlify.app/
MIT License
196 stars 77 forks source link

Google pay is not working on react android demo code #190

Closed mostafa3ly closed 1 year ago

mostafa3ly commented 2 years ago

Platform

Describe the bug Google pay is not working on react android demo code. it logs Not implemented on device on the react android demo code

rdlabo commented 2 years ago

@mostafa3ly Thanks for issue.

This was CapacitorStripeProvider's bug. I fixed and released v3.8.2. Please test it. https://github.com/capacitor-community/stripe/commit/a8ef5f4452321b90b1190f51ac104f42f9fb46ef

Thanks.

mostafa3ly commented 2 years ago

@rdlabo This issue is not fixed yet still having Google play is not implemented on device issue.

I tested your demo code of React with out changing anything it to ensure that the issue is not from my side and it gives me the same issue.

rdlabo commented 2 years ago

@mostafa3ly Did you run npm install and npx cap sync ? In my device, no problem to run.

mostafa3ly commented 2 years ago

@rdlabo yes sure i run npm install then npx cap sync android without changing anything in the app and the google pay button is still dimmed.

and i see that you comment a string in strings.xml file with name stripe_account i don't know if i should replace this value and to what value.

I don't think you test this on react cause you miss @capacitor/android from your dependencies so how you could run android app without it.

note: this issue happens on REACT.

rdlabo commented 2 years ago

Yes, I tested on react-demo. Now, work with no problem. Can Google Pay work on your device?

mostafa3ly commented 2 years ago

@rdlabo yes Google pay is working on my device and i tested it on your demo hosting for web on mobile google chrome browser and it working fine.

i tried your plugin on 4 phones and all of them give the same issue. also tested on emulator Screenshot_20220720_135840

rdlabo commented 2 years ago

I put the word "React" in the title of the Demo to make sure I check it with React-Android. It is indeed working.

S__12345346 S__12345348

Are you sure you run npm install? Make sure the package version of demo/react/node_modules/@capacitor-community/stripe/package.json is 3.8.2-0 or higher.

rdlabo commented 1 year ago

This Issue will be closed because it has not been updated for a long time. If you encounter similar problems, please start a new Issue.