search

capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor
https://capacitor-community-stripe.netlify.app/
MIT License
192 stars 77 forks source link

remove only one key initialization condition #247

Closed timofey97 closed 1 year ago

timofey97 commented 1 year ago

We have a need to work with different stripe accounts in one application. With each payment, we change and initialize different public keys from different companies. But initialization worked painlessly only on ios, on android we found a small flaw in the plugin code. If you remove the check for an empty publishableKey, then everything works as it should)

If possible, please add this to the update or if you have any ideas on how to improve and secure the code, I will be glad to any suggestions

netlify[bot] commented 1 year ago

Deploy Preview for capacitor-community-stripe failed.

Name Link
Latest commit d4370cdb757962f8cab64d3716bf61e0513eb523
Latest deploy log https://app.netlify.com/sites/capacitor-community-stripe/deploys/63b43d0b6aa9ee00091c5693
rdlabo commented 1 year ago

Thanks pull request. We did not consider that kind of usage. Thanks for your contribution!

rdlabo commented 1 year ago

@timofey97 Did you use this plugin for production? If yes, please tell us what app. This help development this plugin.

👉 https://github.com/capacitor-community/stripe/issues/145

Thanks.