search

capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor
https://capacitor-community-stripe.netlify.app/
MIT License
192 stars 77 forks source link

Add ability to change stripe account #25

Closed mortimr closed 3 years ago

mortimr commented 3 years ago

Hi, I'm willing to add a new functionality to this project. We currently cannot set the stripe account id on iOS, and wanted to create a method to do it. I managed to make this quick "fix" but I'm willing to add it to work properly on web and android aswell. It is a very important feature for Stripe Connect users

ihadeed commented 3 years ago

There are examples on how to do it on web + Android here: https://stripe.com/docs/connect/authentication#adding-the-connected-account-id-to-a-client-side-application

I think the implementation should return a new instance of the client for the provided account id, or have another function to reset it.

mortimr commented 3 years ago

Ok, I'll try to do something to create a new instance of the SDK instead of what is currently done. I have some work to finish first. Thanks for your reply !

timsayshey commented 3 years ago

@mortimr Thanks for tackling this -- Any updates?

LinnaeK commented 3 years ago

Will this, or another built in solution for adding sub accounts for Stripe via the plugin be available in the near future?

mortimr commented 3 years ago

Hi ! I'm currently using my own fork for this. I have a pretty filled schedule and I am not going to be able to implement and add it properly in this repo until January. I'll try my best to get back to this and do it. Sorry for the time it takes

LinnaeK commented 3 years ago

Hi @mortimr! Just checking in to see if any progress has been made on including subAccounts with this plugin. Thanks!

timsayshey commented 3 years ago

@mortimr Can you comment with a link to the fork you created?

rdlabo commented 3 years ago

@mortimr I'm rdlabo, and I've joined the maintainer of this plugin. Thanks for pull request. This pull request will be released in v3. Thank you for your contribution.