capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor
https://capacitor-community-stripe.netlify.app/
MIT License
192 stars 77 forks source link

PaymentSheet Google Pay button is no longer compliant with brand guidelines #254

Closed david-nibw closed 1 year ago

david-nibw commented 1 year ago

Is your feature request related to a problem? Please describe. Integration will not be approved because the google pay button does not meet Google's brand guidelines. This appears to be the case for Google Pay Button PaymentSheet and standalone Google Pay Button

Describe the solution you'd like New brand guidelines are here: https://developers.google.com/pay/api/android/guides/brand-guidelines#style

Screenshots image

rdlabo commented 1 year ago

Thanks issue. I created version supporting stripe-android@20.19.0: https://github.com/capacitor-community/stripe/tree/feat/target_33#this-is-pre-release-branch

But this require to change android/variables.gradle.This may affect other plugins. @david-nibw Can you try?

xras-dev commented 1 year ago

it works but there is a delay of 15 seconds when showing the payment sheet. i dont know if its only in my device. screenshot

rdlabo commented 1 year ago

I too can confirm that it appears late. This does not occur with v20.17.0, but starting since v20.18.0🤔

2023-01-26 11:35:35.364 25133-25133/io.ionic.starter W/o.ionic.starter: Method boolean androidx.compose.runtime.snapshots.SnapshotStateList.conditionalUpdate(kotlin.jvm.functions.Function1) failed lock verification and will run slower.
    Common causes for lock verification issues are non-optimized dex code
    and incorrect proguard optimizations.
2023-01-26 11:35:35.364 25133-25133/io.ionic.starter W/o.ionic.starter: Method java.lang.Object androidx.compose.runtime.snapshots.SnapshotStateList.mutate(kotlin.jvm.functions.Function1) failed lock verification and will run slower.
2023-01-26 11:35:35.364 25133-25133/io.ionic.starter W/o.ionic.starter: Method void androidx.compose.runtime.snapshots.SnapshotStateList.update(kotlin.jvm.functions.Function1) failed lock verification and will run slower.

Only the first startup is delayed, not the second or subsequent ones.

rdlabo commented 1 year ago

using v20.11 - 17: https://www.dropbox.com/s/v4mo4lo9h14nngt/screen-20230126-122000.mp4?dl=0 using v20.18 - 19 : https://www.dropbox.com/s/k14ijse0mzykues/screen-20230126-121507.mp4?dl=0

No other settings or APIs have changed.

rdlabo commented 1 year ago

@xras-dev v4.1.2-1 is released. this use stripe-android@20.17.0. Please try.

xras-dev commented 1 year ago

v4.1.2-1 working perfect but v4.1.2 is still using stipe v20.11

Captura de pantalla 2023-01-26 a las 9 50 45
rdlabo commented 1 year ago

That's right. I'm wonder if it is mandatory to give the compileSdkVersion and targetSdkVersion of the project for the plugin. So this will be operated with the next tag for the time being.

xras-dev commented 1 year ago

ok, good work!