capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor
MIT License
185 stars 75 forks source link

Add Stripe Identity #268

Closed staff0rd closed 1 year ago

staff0rd commented 1 year ago

I've added Stripe Identity functionality to the plugin for both Android & iOS. Web is not supported.

Android

https://user-images.githubusercontent.com/6289998/222327412-76a210e6-6651-4939-8645-dde78f33ae54.mp4

iOS

https://user-images.githubusercontent.com/6289998/222326844-3bd72b7c-8489-45ce-a156-157dfea94084.mp4

netlify[bot] commented 1 year ago

Deploy Preview for capacitor-community-stripe ready!

Name Link
Latest commit fc595345eba301db14e8cdef3bd92b68a11471da
Latest deploy log https://app.netlify.com/sites/capacitor-community-stripe/deploys/640020aaecd2500008c0d66d
Deploy Preview https://deploy-preview-268--capacitor-community-stripe.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rdlabo commented 1 year ago

@staff0rd I am impressed and respect your wonderful work. I plan on doing a review within the next couple of days, so please give me a few minutes of your time!

rdlabo commented 1 year ago

Thank you for the pull request! I have merged it with some corrections.

https://github.com/capacitor-community/stripe/commit/0b1ca31784135b5f7fe28852c435bdce3b0f8379

https://github.com/capacitor-community/stripe/commit/42e1539eaa09a112257cd7a211e946a448017fea

I will now write demo code and release it after sufficient validation. Thanks. I appreciate your contribution!

rdlabo commented 1 year ago

@staff0rd IdentityVerificationSheetResultInterface. This was necessary to give priority to the web and to match the behavior of iOS and Android: https://github.com/capacitor-community/stripe/commit/6378915bc906a885b19799905b48d9d41e460290