search

capacitor-community / stripe

Stripe Mobile SDK wrapper for Capacitor
MIT License
185 stars 74 forks source link

feat(native): Make customerEphemeralKeySecret optional #83

Closed doszu closed 2 years ago

doszu commented 2 years ago

When we use the plugin, we need to configure customerEphemeralKeySecret. We can set an empty string (''). This works for Android, but not iOS. The implementation of checking this key is completely different on Android and iOS. Android checks if the keys are empty (== null), on iOS it checks an empty string (== ''). Can we make this variable optional?

rdlabo commented 2 years ago

@doszu Thanks issue. I will fixed this issue next version

rdlabo commented 2 years ago

released: https://github.com/capacitor-community/stripe/releases/tag/v3.0.1

rdlabo commented 2 years ago

@doszu Did you adapt this plugin for production? If yes, please tell us what app. Please help us to develop this plugin in 2022. https://github.com/capacitor-community/stripe/issues/145 Thanks.