capactio / capact

Simple way to manage applications and infrastructure.
https://capact.io
Apache License 2.0
80 stars 19 forks source link

Migrate to `neo4j/graphql` library in Hub #491

Open pkosiec opened 2 years ago

pkosiec commented 2 years ago

Description

Blocked by: https://github.com/capactio/capact/issues/645

As https://github.com/neo4j-graphql/neo4j-graphql-js is now deprecated (see explanation), we need to migrate to https://github.com/neo4j/graphql.

Unfortunately, at the time of writing this description, @additionalLabels directives are not supported - and we use them for zero-downtime content update in Hub.

Reason

  1. The neo4j-graphql-js library is now deprecated and no longer maintained. The neo4j/graphql solution is official library from Neo4j, which we should pick as our solution for Hub GraphQL API.
  2. After bumping security vulnerabilities, we broke GraphQL API contract: https://github.com/capactio/capact/pull/378

Links

pkosiec commented 2 years ago

This issue is no longer blocked, as the @additionalLabels are now supported. However, IMHO we should put this task on hold until we know what's our target database solution is.

mszostok commented 2 years ago

For now, we will stick with Neo4j, and due to an increasing number of conflicts due to out-date libraries we need to address that in the near future.