Closed mszostok closed 2 years ago
Changes proposed in this pull request:
kubeconfig
RUNNER_OPTIONAL_KUBECONFIG_TI
The current impl doesn't handle the cert properly. https://github.com/capactio/capact/blob/d7724224548b5fcdc4e747a39f97e0705d427cfe/cmd/helm-runner/main.go#L41-L48
As a result, I decided to stick to single method for getting kubeconfig and only override the KUBECONFIG env if needed (it's only for a given process execution) as the https://github.com/kubernetes-sigs/controller-runtime/blob/13f1400cd4fc0f15b6877453c50c95d35d146e47/pkg/client/config/config.go#L98-L99 do the job. Unfortunately the underlying methods are private, so I had to use the hack with env variable.
Description
Changes proposed in this pull request:
kubeconfigTypeInstance to Helm Runner viaRUNNER_OPTIONAL_KUBECONFIG_TIIssues
The current impl doesn't handle the cert properly. https://github.com/capactio/capact/blob/d7724224548b5fcdc4e747a39f97e0705d427cfe/cmd/helm-runner/main.go#L41-L48
As a result, I decided to stick to single method for getting kubeconfig and only override the KUBECONFIG env if needed (it's only for a given process execution) as the https://github.com/kubernetes-sigs/controller-runtime/blob/13f1400cd4fc0f15b6877453c50c95d35d146e47/pkg/client/config/config.go#L98-L99 do the job. Unfortunately the underlying methods are private, so I had to use the hack with env variable.
Related issue(s)