capactio / capact

Simple way to manage applications and infrastructure.
https://capact.io
Apache License 2.0
80 stars 19 forks source link

Get rid of `sed` usage inside Capact release pipeline scripts #622

Open pkosiec opened 2 years ago

pkosiec commented 2 years ago

Description

Refactor hack/make-release.sh and hack/release-charts.sh script:

Alternatives:

See the discussion https://github.com/capactio/capact/pull/617

Reason

The current solution is very shortsighted. In case of Dashboard tag, the current approach replaces any tag property, which is a generic word. It's a matter of time when we have such duplicated property in the values.yaml file. Same with other properties, like branch, which could occur multiple times, as we have multiple sources support in Populator. Should we build more complex sed one-liners in future? Definitely not, so that would need to be addressed.