The current solution is very shortsighted. In case of Dashboard tag, the current approach replaces any tag property, which is a generic word. It's a matter of time when we have such duplicated property in the values.yaml file. Same with other properties, like branch, which could occur multiple times, as we have multiple sources support in Populator. Should we build more complex sed one-liners in future? Definitely not, so that would need to be addressed.
Description
Refactor
hack/make-release.sh
andhack/release-charts.sh
script:sed
usageAlternatives:
yq
(however, it reformats the file, which could be a concern for some)See the discussion https://github.com/capactio/capact/pull/617
Reason
The current solution is very shortsighted. In case of Dashboard tag, the current approach replaces any
tag
property, which is a generic word. It's a matter of time when we have such duplicated property in thevalues.yaml
file. Same with other properties, likebranch
, which could occur multiple times, as we have multiple sources support in Populator. Should we build more complexsed
one-liners in future? Definitely not, so that would need to be addressed.