capactio / capact

Simple way to manage applications and infrastructure.
https://capact.io
Apache License 2.0
80 stars 19 forks source link

Fix Helm Implementation generation for empty objects and arrays in Capact CLI #664

Closed pkosiec closed 2 years ago

pkosiec commented 2 years ago

Description

Changes proposed in this pull request:

Testing

To test this PR, check out this branch and run:

# with old CLI
capact manifest generate implementation helm cap.implementation.secret-storage-backend.install ./deploy/kubernetes/charts/secret-storage-backend -o /tmp/generated-old

# with new CLI, from this branch
go run ./cmd/cli/main.go manifest generate implementation helm cap.implementation.secret-storage-backend.install ./deploy/kubernetes/charts/secret-storage-backend -o /tmp/generated-new

You can compare the values with real manifests from https://github.com/capactio/hub-manifests/blob/main/manifests/implementation/aws/secrets-manager/storage/install.yaml

For more details, see the Steps to reproduce from #663.

Related issue(s)

Resolves #663