capactio / capact

Simple way to manage applications and infrastructure.
https://capact.io
Apache License 2.0
80 stars 19 forks source link

Validate Type for storage backends #700

Closed mkuziemko closed 2 years ago

mkuziemko commented 2 years ago

Description

Changes proposed in this pull request:

Testing

There was created a new generic storage backend schema in this PR.

  1. Checkout this PR
  2. Create cluster using DISABLE_MONITORING_INSTALLATION=true make dev-cluster
  3. Change manifests source to my branch:
    kubectl set env deploy/capact-hub-public -n capact-system -c hub-public-populator MANIFESTS_SOURCES="github.com/mkuziemko/hub-manifests?ref=validate_storage_schema"
  4. Build capact CLI make build-tool-cli
  5. Execute tests on the hub-manifests capact manifests validate manifests/ -r --server-side
  6. Try to edit cap.type.capactio.capact.validation.schema by removing url from required and repeat step 5. It should return validation errors.

There was also added a UT for this functionality.

Related issue(s)