capactio / hub-manifests

Holds Capact Hub manifests
Apache License 2.0
1 stars 8 forks source link

Make Capact upgrade schema more relaxed #50

Closed mszostok closed 2 years ago

mszostok commented 2 years ago

Description

On CI we got error:

  message: |-
    Cannot render given action: while rendering Action: while validating required and additional input data: 1 validation error detected:
    - Parameters "input-parameters":
        * override.capactValues.hub-public: Additional property populator is not allowed (will retry - 14/15)

see: https://github.com/capactio/capact/runs/4802575550?check_suite_focus=true. The previous definition, that we had, was invalid and the validation was executed only against version field.

Changes proposed in this pull request:

Testing

Submitted input by CI:

{
  "override": {
    "CapactStringOverrides": null,
    "CertManagerStringOverrides": null,
    "IngressStringOverrides": null,
    "capactValues": {
      "engine": {
        "testSetup": {
          "enabled": true
        }
      },
      "gateway": {
        "resources": {
          "limits": {
            "cpu": "300m",
            "memory": "128Mi"
          },
          "requests": {
            "cpu": "100m",
            "memory": "48Mi"
          }
        }
      },
      "global": {
        "containerRegistry": {
          "overrideTag": "1847b74",
          "path": "ghcr.io/capactio"
        }
      },
      "hub-local": {
        "resources": {
          "limits": {
            "cpu": "400m",
            "memory": "512Mi"
          },
          "requests": {
            "cpu": "200m",
            "memory": "128Mi"
          }
        }
      },
      "hub-public": {
        "populator": {},
        "resources": {
          "limits": {
            "cpu": "400m",
            "memory": "512Mi"
          },
          "requests": {
            "cpu": "200m",
            "memory": "128Mi"
          }
        }
      },
      "notes": {
        "printInsecure": false
      }
    },
    "helmRepoURL": "https://storage.googleapis.com/capactio-latest-charts",
    "neo4jValues": {
      "neo4j": {
        "core": {
          "resources": {
            "limits": {
              "cpu": "1",
              "memory": "3072Mi"
            },
            "requests": {
              "cpu": "500m",
              "memory": "1768Mi"
            }
          }
        }
      }
    }
  },
  "version": "0.5.0-1847b74"
}

use current JSON Schema from PR and validate input object, e.g. via https://www.jsonschemavalidator.net/