search

capaj / require-globify

transform for browserify, which allows to require files with globbing expressions
MIT License
70 stars 11 forks source link

Fix extension missing with module path #6 #7

Closed mparpaillon closed 9 years ago

mparpaillon commented 9 years ago

See #6

mparpaillon commented 9 years ago

I don't get it. You accepted the MR but commented out the code. So nothing is fixed in 1.2.0...

call-a3 commented 9 years ago

I'm actually still working on this, and while trying to fix this and other issues, I'm doing an overhaul of how matched files are processed. Besides, your pull request didn't pass our unit tests, so I could argue you didn't fix the problem either. ;)

Could you please write up some test(s) that replicate the bug you are trying to fix/shows what the expected output would be?

mparpaillon commented 9 years ago

I'm using my fork right now and it works... Anyway, I won't add any unit tests. I don't want to spend more time on this. If you don't want your package to work with hbs files, it's your choice

call-a3 commented 9 years ago

Of course I understand if you don't want to put a lot of time and effort in this.

The plan is make require-globify work with any extension, which the current version (1.1.0) apparently does not support. Your PR fixes this, but doesn't fix some other issues that have been lying around which I also want to fix in the next version.

1.2.0 is not out yet, so I suggest you keep using your own fork for a little while longer and keep an eye out for when it is released. Hopefully then all your (and others' problems) will be solved :)