search

capaj / vscode-exports-autocomplete

finds javascript ES6 exports in your project and autocompletes them when writing javascript statements
MIT License
18 stars 6 forks source link

Feature request: Support quote styles #16

Open doctyper opened 7 years ago

doctyper commented 7 years ago

Our style guide at work calls for double quotes, but there's currently no way to set this.

flying-sheep commented 7 years ago

for implementation, we should extract usesStandard and eslintCLI from uses-semi.js and use both to find the quote style (which btw could also be `!)

doctyper commented 7 years ago

Agreed, but I think you should allow a setting to override the check. I think it's better to be explicit than implicit.

flying-sheep commented 7 years ago

@capaj why the 😕 face?

capaj commented 7 years ago

@flying-sheep who the hell uses backticks for import strings? that's just plain crazy 😈

flying-sheep commented 7 years ago

heh, i bet there’s somewhere out there. but it’s not hard to support. shall i make a PR?

capaj commented 7 years ago

@flying-sheep I will add the config override. If you can, please extract that bit from uses-semi.js

flying-sheep commented 7 years ago

OK

capaj commented 7 years ago

@doctyper 0.3.3 has been released with the config added. Feel free to try it out and let me know if you have any issues. I will leave this opened, because it would be nice to have the quote style set automagically for each project based on eslint settings.