Add support for multiple Firebase projects, and switching between apps for Firebase Authentication

capawesome-team / capacitor-firebase

⚡️ Firebase plugins for Capacitor. Supports Android, iOS and the Web.

https://capawesome.io/plugins/firebase/

Apache License 2.0

405 stars 102 forks source link

Add support for multiple Firebase projects, and switching between apps for Firebase Authentication #711

Closed emmernme closed 2 weeks ago

emmernme commented 2 months ago

This PR implements support for initializing multiple Firebase Apps with custom configurations. This can be used by individual plugins by overriding the currently used app. For now, this is only implemented and tested for Firebase Authentication, as this was the use case I personally needed, but it should be simple enough to implement for other plugins as well.

I have not had the change to thoroughly test the web implementation of this, so that may need some more work.

Re. issue #653.

Pull request checklist

[On iOS and Android] The changes have been tested successfully.
[Y] A changeset has been created (npm run changeset).
[Y] I have read and followed the pull request guidelines.

emmernme commented 2 months ago

I've made the desired changes, and implemented FirebaseApp.getApps() so that it returns an array of app names – we could adapt this to return more info, such as the appId, but that doesn't seem necessary as the usage of initializeApp ensures the user can keep track of app names and the connected options in their implementation.

robingenz commented 2 months ago

Thanks, i will get back to you soon. I have a lot to do at the moment.

emmernme commented 3 weeks ago

Just letting you know, I've discovered several bugs in the Android implementation that will need fixing before this can be implemented. I'm currently pretty stuck, but will update once I've come up with a solution.

emmernme commented 2 weeks ago

I've made some final touches on the Android implementation, ensuring generic OAuth & Apple works as expected. Google for Android is not something that's salveagable using their own libraries, my current workaround is based on using the generic OAuth handler for Google authentication on Android. This seems to work fine, so for now, that's what I've gone for for myself. Google is also deprecating GoogleSignInClient in favor of CredentialManager, which would need to be adapted further in the future, so I decided not to go down that road for now. The branch google-generic in my repo adds these changes, so it's up to you if you want to merge that in or close this for now. :)

robingenz commented 2 weeks ago

Hey @emmernme, thank you for the update. In this case, I will close this PR for the time being and wait to see if there is more demand for this feature. If so, this PR can be reopened later. Nevertheless, thank you for your contribution.