capawesome-team / capacitor-firebase

⚑️ Firebase plugins for Capacitor. Supports Android, iOS and the Web.
https://capawesome.io/plugins/firebase/
Apache License 2.0
382 stars 99 forks source link

bug(authentication): Google access token sometimes does not have scopes requested on sign-in #725

Closed nkalupahana closed 6 days ago

nkalupahana commented 1 week ago

Plugin(s)

Version

6.1.0

Platform(s)

Current behavior

Access token coming from Sign In With Google often contains scopes requested at sign-in, but sometimes doesn't.

Expected behavior

Access token should always contain requested scopes. This can be done by explicitly specifying the scopes when requesting an access token.

Reproduction

This is from a race condition, so it cannot be reliably reproduced.

Steps to reproduce

This is from a race condition, so it cannot be reliably reproduced. My end users are affected, and I have identified and tested a fix: nkalupahana/baseline#401

Other information

I will be submitting a PR that fixes this shortly (today).

Capacitor doctor

πŸ’Š   Capacitor Doctor  πŸ’Š 

Latest Dependencies:

  @capacitor/cli: 6.1.2
  @capacitor/core: 6.1.2
  @capacitor/android: 6.1.2
  @capacitor/ios: 6.1.2

Installed Dependencies:

  @capacitor/cli: 6.0.0
  @capacitor/core: 6.1.0
  @capacitor/android: 6.1.0
  @capacitor/ios: 6.1.0

[success] iOS looking great! πŸ‘Œ
[success] Android looking great! πŸ‘Œ

Before submitting