capawesome-team / capacitor-firebase

⚡️ Firebase plugins for Capacitor. Supports Android, iOS and the Web.
https://capawesome.io/plugins/firebase/
Apache License 2.0
405 stars 102 forks source link

fix(authentication): explicitly request Google auth token with provided scopes on Android #726

Closed nkalupahana closed 1 month ago

nkalupahana commented 1 month ago

This PR explicitly requests scopes when getting a Google access token post-Sign In with Google.

It looks like not requesting scopes explicitly works most of the time, but not all of the time. I had two users with this bug (nkalupahana/baseline#402), and this change fixed it for them (patch). This PR upstreams our patch.

Closes #725

Pull request checklist

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

@capacitor-firebase/analytics

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/analytics@726 ```

@capacitor-firebase/app

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app@726 ```

@capacitor-firebase/app-check

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app-check@726 ```

@capacitor-firebase/authentication

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/authentication@726 ```

@capacitor-firebase/crashlytics

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/crashlytics@726 ```

@capacitor-firebase/firestore

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/firestore@726 ```

@capacitor-firebase/functions

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/functions@726 ```

@capacitor-firebase/messaging

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/messaging@726 ```

@capacitor-firebase/performance

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/performance@726 ```

@capacitor-firebase/remote-config

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/remote-config@726 ```

@capacitor-firebase/storage

``` npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/storage@726 ```

commit: 8be3cec

nkalupahana commented 1 month ago

@robingenz all set!