capawesome-team / capacitor-mlkit

⚡️ ML Kit plugins for Capacitor. Supports Android and iOS.
https://capawesome.io/plugins/mlkit/
Apache License 2.0
147 stars 46 forks source link

bug(barcode-scanning): missing privacy manifest #178

Closed akships closed 1 month ago

akships commented 3 months ago

Plugin(s)

Current problem

When I push my app to apple there is always this warning about privacy

privacy-apple

Preferred solution

I think this is due to dependency to MLKIT (which is dependent to an old version of GoogleToolboxForMac) version which is 5.0.0 currently and should be at least 6.0.0 or even 7.0.0. On those latest versions the privacy issue is fixed.

Is it possible to update podspec to fix this or another solution in mind ?

Alternative options

No response

Additional context

Using current latest version of package 6.1.0

Before submitting

robingenz commented 3 months ago

According to the changelog, the latest version for GoogleMLKit/BarcodeScanning is 5.0.0. This version is used by the plugin.

Mercury-Ong commented 3 months ago

Hi! I updated the GoogleMLKit/BarcodeScanning to 6.0.0 manually and ran pod update. These packages were updated, and everything seems to be working fine. (for now)

Installing CapacitorMlkitBarcodeScanning 6.1.0
Installing GoogleMLKit 6.0.0 (was 5.0.0)
Installing GoogleToolboxForMac 4.2.1 (was 2.3.2) 
Installing MLKitBarcodeScanning 5.0.0 (was 4.0.0)
Installing MLKitCommon 11.0.0 (was 10.0.0)
Installing MLKitVision 7.0.0 (was 6.0.0)

The privacy policy was added on version 4.2.0 for GoogleToolboxForMac.

robingenz commented 3 months ago

I have created a PR to update the pods: https://github.com/capawesome-team/capacitor-mlkit/pull/179. Unfortunately, it contains breaking changes, so I can't merge the PR yet. You can use the pre-release in the meantime:

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/barcode-scanning@327eae6
robingenz commented 1 month ago

Closed by #179. Please install the latest version using the next tag:

npm install @capacitor-mlkit/barcode-scanning@next
geckozr commented 2 weeks ago

While updating to ^7.0.0-next.1, I'm receiving this error:

[capacitor] ✖ update ios - failed!
[capacitor] [error] Analyzing dependencies
[capacitor]         [!] CocoaPods could not find compatible versions for pod "GoogleMLKit/BarcodeScanning":
[capacitor]         In Podfile:
[capacitor]         CapacitorMlkitBarcodeScanning (from `../../node_modules/@capacitor-mlkit/barcode-scanning`) was resolved to 7.0.0-next.1, which depends on
[capacitor]         GoogleMLKit/BarcodeScanning (= 7.0.0)
[capacitor]         
[capacitor]         Specs satisfying the `GoogleMLKit/BarcodeScanning (= 7.0.0)` dependency were found, but they required a higher minimum deployment target.
[capacitor]       

To correctly build the application, I had to increase the iOS platform version in my Podfile to: platform :ios, '15.5'

Is this supposed to be correct?

robingenz commented 2 weeks ago

@geckozr Yes, see BREAKING.md. That's the reason why we can't publish a new latest version before the next major release.

hoangqwe159 commented 1 week ago

@robingenz can you manage to merge the fix for GoogleMLKit/BarcodeScanning in version 6, please? My project cannot increase the the IOS platform version to 15.5; I believe it is the same for many others.

robingenz commented 1 week ago

@hoangqwe159 That's the problem. We have to increase the minimum deployment target to be able to merge it. This is a requirement from the ML Kit Barcode Scanning SDK.