bug: FilePicker on ios - wrong selection order

[stephan-fischer]

Plugin(s)

• [ ] Android Foreground Service
• [ ] Android Battery Optimization
• [ ] App Update
• [ ] Background Task
• [ ] Badge
• [ ] Bluetooth Low Energy
• [ ] Cloudinary
• [ ] Datetime Picker
• [ ] File Compressor
• [ ] File Opener
• [X] File Picker
• [ ] Live Update
• [ ] Managed Configurations
• [ ] NFC
• [ ] Photo Editor
• [ ] Printer
• [ ] Screen Orientation
• [ ] Zip

Version

5.0.0

Platform(s)

• [ ] Android
• [X] iOS
• [ ] Web

Current behavior

if i execute pickImages the end selection is not correct. If i use the ordered param - the selection is always random.

Expected behavior

if i select the images without ordered - it should be sorted by date, if i select with .ordered param, it should have the exact order

Reproduction

-

Steps to reproduce

 const media = await FilePicker.pickImages({
            multiple: true,
            readData: false,
            ordered: true
        });

Other information

The problem is following:

temporaryUrls.append(temporaryUrl)

in FilePicker.swift. Because the async function result.itemProvider.loadFileRepresentation(forTypeIdentifier: UTType.image.identifier, completionHandler: { is randomly finished - means one image could have a longer time etc.

Fix:

// for-in with index:
  for (index, result) in results.enumerated() {
// set count:
        var temporaryUrls = Array<URL?>(repeating: nil, count: results.count)
...

// add index at the right position:
           let temporaryUrl = try self.saveTemporaryFile(url)
                        temporaryUrls[index] = temporaryUrl

// set the final right sorted urls
    let finalUrls = temporaryUrls.compactMap { $0 }
            self.plugin?.handleDocumentPickerResult(urls: finalUrls, error: nil)

Capacitor doctor

-

Before submitting

• [X] I have read and followed the bug report guidelines.
• [X] I have attached links to possibly related issues and discussions.
• [X] I understand that incomplete issues (e.g. without reproduction) are closed.

[robingenz]

Thank you for your request. Would you be willing to create a PR?

[stephan-fischer]

yes, this week i will send a PR 😉