search

capistrano-plugins / capistrano-faster-assets

Skips asset compilation if none of the assets were changed since last release.
MIT License
187 stars 38 forks source link

Request: Tool that attempts to detect the dreaded 'ERB in your assets' #10

Closed dpritchett closed 9 years ago

dpritchett commented 9 years ago

I'm starting with this, but I don't really know that it's gonna help much:

find . | grep -E "(css|coffee)"  | xargs -n1 grep "<%"

Thoughts?

rhomeister commented 9 years ago

Could you elaborate a little about what you're trying to accomplish and why?

On 23 June 2015 at 01:56, Daniel J. Pritchett notifications@github.com wrote:

I'm starting with this, but I don't really know that it's gonna help much:

find . | grep -E "(css|coffee)" | xargs -n1 grep "<%"

Thoughts?

— Reply to this email directly or view it on GitHub https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10 .

dpritchett commented 9 years ago

I'd like to use this extension without suffering the caveat in your README. I work with Spree a lot and there are many files passed through the pipeline. A method to search my directory tree for probable assets that include ERB snippets would make it feel safer.

On Mon, Jun 22, 2015, 7:21 PM Ruben Stranders notifications@github.com wrote:

Could you elaborate a little about what you're trying to accomplish and why?

On 23 June 2015 at 01:56, Daniel J. Pritchett notifications@github.com wrote:

I'm starting with this, but I don't really know that it's gonna help much:

find . | grep -E "(css|coffee)" | xargs -n1 grep "<%"

Thoughts?

— Reply to this email directly or view it on GitHub < https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10> .

— Reply to this email directly or view it on GitHub https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114311121 .

rhomeister commented 9 years ago

OK. Clear. Wouldn't it be easier to scan for files with an extension of .erb instead?

On 23 June 2015 at 02:49, Daniel J. Pritchett notifications@github.com wrote:

I'd like to use this extension without suffering the caveat in your README. I work with Spree a lot and there are many files passed through the pipeline. A method to search my directory tree for probable assets that include ERB snippets would make it feel safer.

On Mon, Jun 22, 2015, 7:21 PM Ruben Stranders notifications@github.com wrote:

Could you elaborate a little about what you're trying to accomplish and why?

On 23 June 2015 at 01:56, Daniel J. Pritchett notifications@github.com wrote:

I'm starting with this, but I don't really know that it's gonna help much:

find . | grep -E "(css|coffee)" | xargs -n1 grep "<%"

Thoughts?

— Reply to this email directly or view it on GitHub < https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10

.

— Reply to this email directly or view it on GitHub < https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114311121

.

— Reply to this email directly or view it on GitHub https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114314048 .

dpritchett commented 9 years ago

Maybe I misunderstood the warning. I was thinking about files that have inline ERB, not pure ERB files themselves. Mostly, I don't know what to look for even though I know how to find and grep.

On Mon, Jun 22, 2015 at 8:12 PM, Ruben Stranders notifications@github.com wrote:

OK. Clear. Wouldn't it be easier to scan for files with an extension of .erb instead?

On 23 June 2015 at 02:49, Daniel J. Pritchett notifications@github.com wrote:

I'd like to use this extension without suffering the caveat in your README. I work with Spree a lot and there are many files passed through the pipeline. A method to search my directory tree for probable assets that include ERB snippets would make it feel safer.

On Mon, Jun 22, 2015, 7:21 PM Ruben Stranders notifications@github.com wrote:

Could you elaborate a little about what you're trying to accomplish and why?

On 23 June 2015 at 01:56, Daniel J. Pritchett < notifications@github.com> wrote:

I'm starting with this, but I don't really know that it's gonna help much:

find . | grep -E "(css|coffee)" | xargs -n1 grep "<%"

Thoughts?

— Reply to this email directly or view it on GitHub <

https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10

.

— Reply to this email directly or view it on GitHub <

https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114311121

.

— Reply to this email directly or view it on GitHub < https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114314048

.

— Reply to this email directly or view it on GitHub https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114316371 .

rhomeister commented 9 years ago

Pretty sure that Javascript and CSS files containing ERB code must have an .erb extension. Why are you specifically concerned about this problem? Which symptoms are you experiencing? My advice: don't solve problems that don't exist (yet).

On 23 June 2015 at 03:44, Daniel J. Pritchett notifications@github.com wrote:

Maybe I misunderstood the warning. I was thinking about files that have inline ERB, not pure ERB files themselves. Mostly, I don't know what to look for even though I know how to find and grep.

On Mon, Jun 22, 2015 at 8:12 PM, Ruben Stranders <notifications@github.com

wrote:

OK. Clear. Wouldn't it be easier to scan for files with an extension of .erb instead?

On 23 June 2015 at 02:49, Daniel J. Pritchett notifications@github.com wrote:

I'd like to use this extension without suffering the caveat in your README. I work with Spree a lot and there are many files passed through the pipeline. A method to search my directory tree for probable assets that include ERB snippets would make it feel safer.

On Mon, Jun 22, 2015, 7:21 PM Ruben Stranders < notifications@github.com> wrote:

Could you elaborate a little about what you're trying to accomplish and why?

On 23 June 2015 at 01:56, Daniel J. Pritchett < notifications@github.com> wrote:

I'm starting with this, but I don't really know that it's gonna help much:

find . | grep -E "(css|coffee)" | xargs -n1 grep "<%"

Thoughts?

— Reply to this email directly or view it on GitHub <

https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10

.

— Reply to this email directly or view it on GitHub <

https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114311121

.

— Reply to this email directly or view it on GitHub <

https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114314048

.

— Reply to this email directly or view it on GitHub < https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114316371

.

— Reply to this email directly or view it on GitHub https://github.com/capistrano-plugins/capistrano-faster-assets/issues/10#issuecomment-114324531 .

rhomeister commented 9 years ago

Closing due to lack of further input.