search

capistrano-plugins / capistrano-unicorn-nginx

Capistrano tasks for automatic and sensible unicorn + nginx configuration
MIT License
175 stars 81 forks source link

Allow SSL certificates to be somewhere else than /etc/ssl/certs/ #100

Closed wynksaiddestroy closed 7 years ago

wynksaiddestroy commented 7 years ago

I'm using Let's Encrypt to create my SSL certificates. When using the recommended method by running Certbot the certificates are placed in /etc/letsencrypt/live/www.foobar.me/ for example.

Unfortunately the options :nginx_ssl_certand :nginx_ssl_cert_key will only accept filenames that are relative to /etc/ssl/certs/ and /etc/ssl/private/.

Wouldn't it be useful to accept absolute paths and filenames in equal measure?

wynksaiddestroy commented 7 years ago

While browsing the source code I've found the two (undocumented) options :nginx_ssl_cert_path and :nginx_ssl_cert_key_path which solved my problem.

Should I add these to the full options list on the wiki page?

wynksaiddestroy commented 7 years ago

I've updated the options wiki page. Have a look at wynksaiddestroy/capistrano-unicorn-nginx-wiki@f63f3fe and merge if there's nothing wrong with the additions.

wynksaiddestroy commented 7 years ago

If you have a minute to spare could you please have a look this issue, @griffithac? I’d like to clean up my repositories. Thanks in advance.

griffithac commented 7 years ago

@wynksaiddestroy your updates to the wiki have been added. Unfortunately pull requests for wikis are kind of a pain to setup, so you just copied your changes in manually. Thanks for your work on this. It is much more complete now and easier to make sense of.