search

capistrano-plugins / capistrano-unicorn-nginx

Capistrano tasks for automatic and sensible unicorn + nginx configuration
MIT License
175 stars 81 forks source link

Don't chown existing certificates #101

Closed wynksaiddestroy closed 7 years ago

wynksaiddestroy commented 7 years ago

Certificates that aren't uploaded by Capistrano and therefore already exist shouldn't be touched.

griffithac commented 7 years ago

@rhomeister, I think @wynksaiddestroy is correct here. Changing the ownership of certs that may not have been uploaded by the gem could be surprising behavior. Any objection to merging this?

griffithac commented 7 years ago

@rhomeister, @wynksaiddestroy after further review I see that this code will not run if the certs already exist on the server anyway. This should never be an issue.

https://github.com/capistrano-plugins/capistrano-unicorn-nginx/blob/master/lib/capistrano/tasks/nginx.rake#L55