capistrano-plugins / capistrano-unicorn-nginx

Capistrano tasks for automatic and sensible unicorn + nginx configuration

MIT License

175 stars 81 forks source link

setup nginx for load balancing, setting HOME variable in unicorn_init, and fix for missing nginx log directory when web is a non-release role #13

Closed rhomeister closed 10 years ago

rhomeister commented 10 years ago

(temporary?) fix to problem in unicorn_init script whereby HOME variable is not set (possible alternative to https://github.com/bruno-/capistrano-unicorn-nginx/pull/11)
create log directory for nginx if web is a non-release role
connect over TCP/IP if there are multiple app roles and setup nginx for load balancing

bruno- commented 10 years ago

Hi, thanks for this contribution! I've added you as a collaborator, but let's not push directly to master but open pull requests and do code reviews for each other.

Do you have any preferences in regards to git? I aspire to these guidelines (and I think they are also accepted in the community) so let's hold to those.

11 is merged so I think that update can be removed.

There are a lot of updates in this pull req, please give me some time to do a review and leave comments.

rhomeister commented 10 years ago

Thanks for the guidelines. I will adhere to them next time.

rhomeister commented 10 years ago

Let me know when you've finished reviewing this PR. I'll update this pull request and create a new one for the config overwrite.

rhomeister commented 10 years ago

@bruno- Have you finished your code review? If so, I'll submit PRs for the two separate features we've identified in this PR.

bruno- commented 10 years ago

Hey @rhomeister, sorry for the long-ish wait. Feel free to do the updates/improvements in your pull requests at will - no need to wait for me to confirm "code review end".

So yea, let's do the code updates and hopefully we can get this merged today.

rhomeister commented 10 years ago

Closing to split this up into multiple PRs.