Closed rhomeister closed 10 years ago
Hi, thanks for this contribution! I've added you as a collaborator, but let's not push directly to master but open pull requests and do code reviews for each other.
Do you have any preferences in regards to git? I aspire to these guidelines (and I think they are also accepted in the community) so let's hold to those.
There are a lot of updates in this pull req, please give me some time to do a review and leave comments.
Thanks for the guidelines. I will adhere to them next time.
Let me know when you've finished reviewing this PR. I'll update this pull request and create a new one for the config overwrite.
@bruno- Have you finished your code review? If so, I'll submit PRs for the two separate features we've identified in this PR.
Hey @rhomeister, sorry for the long-ish wait. Feel free to do the updates/improvements in your pull requests at will - no need to wait for me to confirm "code review end".
So yea, let's do the code updates and hopefully we can get this merged today.
Closing to split this up into multiple PRs.