unicorn service restart keeps old service around

[navjeetc]

After capistrano deployment the old unicorn process seems to be kept around. When I do ps the old process is listed as "master (old)". Is that normal?

[navjeetc]

Here is script for the unicorn service

#!/bin/bash
### BEGIN INIT INFO
# Provides: unicorn
# Required-Start: $remote_fs $syslog
# Required-Stop: $remote_fs $syslog
# Default-Start: 2 3 4 5
# Default-Stop: 0 1 6
# Short-Description: Manage unicorn server
# Description: Start, stop, restart unicorn server for a specific application.
### END INIT INFO
set -e

# Feel free to change any of the following variables for your app:
TIMEOUT=${TIMEOUT-60}
APP_ROOT=/home/rails/fsi/current
PID=/home/rails/fsi/shared/tmp/pids/unicorn.pid

AS_USER=rails
CMD="export HOME; true "${HOME:=$(getent passwd "$AS_USER" | cut -d: -f6;)}" ; cd $APP_ROOT && ( RAILS_RELATIVE_URL_ROOT=/fsi /usr/local/rvm/bin/rvm default do bundle exec unicorn -D -c /home/rails/fsi/shared/config/unicorn.rb -E production )"

set -u

OLD_PIN="$PID.oldbin"

sig () {
  test -s "$PID" && kill -$1 `cat $PID`
}

oldsig () {
  test -s $OLD_PIN && kill -$1 `cat $OLD_PIN`
}

run () {
  if [ "$(id -un)" = "$AS_USER" ]; then
    eval $1
  else
    su -c "$1" - $AS_USER
  fi
}

case "$1" in
start)
  sig 0 && echo >&2 "Already running" && exit 0
  run "$CMD"
  ;;
stop)
 sig QUIT && exit 0
  echo >&2 "Not running"
  ;;
force-stop)
  sig TERM && exit 0
  echo >&2 "Not running"
  ;;
restart|reload)
  sig USR2 && echo reloaded OK && exit 0
  echo >&2 "Couldn't reload, starting '$CMD' instead"
  run "$CMD"
  ;;
upgrade)
  if sig USR2 && sleep 2 && sig 0 && oldsig QUIT
  then
    n=$TIMEOUT
    while test -s $OLD_PIN && test $n -ge 0
    do
      printf '.' && sleep 1 && n=$(( $n - 1 ))
    done
    echo

    if test $n -lt 0 && test -s $OLD_PIN
    then
      echo >&2 "$OLD_PIN still exists after $TIMEOUT seconds"
      exit 1
    fi
    exit 0
  fi
  echo >&2 "Couldn't upgrade, starting '$CMD' instead"
  run "$CMD"
  ;;
reopen-logs)
  sig USR1
  ;;
*)
  echo >&2 "Usage: $0 <start|stop|restart|upgrade|force-stop|reopen-logs>"
  exit 1
  ;;
esac

[thepug]

restart should be sending the HUP signal?

according to the docs a USR2 signal will need a QUIT signal to the old process. That is why you see the upgrade option in that script.

https://github.com/defunkt/unicorn/blob/master/Documentation/unicorn.1.txt#L115

[thepug]

@rhomeister It seems the init script isn't correct in sending a USR2 signal for restart. Needs HUP or the upgrade options.

https://github.com/defunkt/unicorn/blob/master/examples/init.sh#L42

[hector]

I fixed the problem in my server. See the explanation about the signals in the pull-request https://github.com/capistrano-plugins/capistrano-unicorn-nginx/pull/93. Until it gets merged you can use my fork.

[Preen]

This is merged now.