search

capistrano-plugins / capistrano-unicorn-nginx

Capistrano tasks for automatic and sensible unicorn + nginx configuration
MIT License
175 stars 81 forks source link

Unicorn restart fails in a multi-stage deploy #68

Closed mshappe closed 8 years ago

mshappe commented 9 years ago

cap staging-a staging-b deploy

unicorn:restart only remembers one of the unicorn_service names and uses it for hosts in all stages, rather than using the correct name for the correct stages.

mshappe commented 9 years ago 
INFO [57f42f25] Finished in 0.891 seconds with exit status 0 (successful).
INFO [d6d23030] Running /usr/bin/env service unicorn_passare-app_staging-b restart as passare@staging-b-app-2.passare.internal
DEBUG [d6d23030] Command: ( JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64 PATH=$PATH /usr/bin/env service unicorn_passare-app_staging-b restart )
INFO [3a9d5a54] Running /usr/bin/env service unicorn_passare-app_staging-b restart as passare@staging-a-app-1.passare.internal
DEBUG [3a9d5a54] Command: ( JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64 PATH=$PATH /usr/bin/env service unicorn_passare-app_staging-b restart )
INFO [be136eae] Running /usr/bin/env service unicorn_passare-app_staging-b restart as passare@staging-a-app-2.passare.internal
DEBUG [be136eae] Command: ( JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64 PATH=$PATH /usr/bin/env service unicorn_passare-app_staging-b restart )
INFO [4a461dc1] Running /usr/bin/env service unicorn_passare-app_staging-b restart as passare@staging-b-app-1.passare.internal
DEBUG [4a461dc1] Command: ( JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64 PATH=$PATH /usr/bin/env service unicorn_passare-app_staging-b restart )
DEBUG [d6d23030]    reloaded OK
DEBUG [d6d23030]
INFO [d6d23030] Finished in 0.151 seconds with exit status 0 (successful).
DEBUG [be136eae]    unicorn_passare-app_staging-b: unrecognized service
rhomeister commented 9 years ago

If I understand correctly, you're deploying to two different stages in one go. We didn't test for this way of using the gem. I'd like to invite you to submit a pull request to fix this issue.

On 18 May 2015 at 21:17, Michael Scott Shappe notifications@github.com wrote:

INFO [57f42f25] Finished in 0.891 seconds with exit status 0 (successful). INFO [d6d23030] Running /usr/bin/env service unicorn_passare-app_staging-b restart as passare@staging-b-app-2.passare.internal DEBUG [d6d23030] Command: ( JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64 PATH=$PATH /usr/bin/env service unicorn_passare-app_staging-b restart ) INFO [3a9d5a54] Running /usr/bin/env service unicorn_passare-app_staging-b restart as passare@staging-a-app-1.passare.internal DEBUG [3a9d5a54] Command: ( JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64 PATH=$PATH /usr/bin/env service unicorn_passare-app_staging-b restart ) INFO [be136eae] Running /usr/bin/env service unicorn_passare-app_staging-b restart as passare@staging-a-app-2.passare.internal DEBUG [be136eae] Command: ( JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64 PATH=$PATH /usr/bin/env service unicorn_passare-app_staging-b restart ) INFO [4a461dc1] Running /usr/bin/env service unicorn_passare-app_staging-b restart as passare@staging-b-app-1.passare.internal DEBUG [4a461dc1] Command: ( JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64 PATH=$PATH /usr/bin/env service unicorn_passare-app_staging-b restart ) DEBUG [d6d23030] reloaded OK DEBUG [d6d23030] INFO [d6d23030] Finished in 0.151 seconds with exit status 0 (successful). DEBUG [be136eae] unicorn_passare-app_staging-b: unrecognized service

— Reply to this email directly or view it on GitHub https://github.com/capistrano-plugins/capistrano-unicorn-nginx/issues/68#issuecomment-103180150 .

rhomeister commented 8 years ago

Closing due to lack of activity. Happy to accept a PR though.