Closed spajic closed 4 years ago
1 Warning | |
---|---|
:warning: | Please update CHANGELOG.md with a description of your changes. If this PR is not a user-facing change (e.g. just refactoring), you can disregard this. |
Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes.
Here's an example of a CHANGELOG.md entry (place it immediately under the * Your contribution here!
line):
* [#101](https://github.com/capistrano/bundler/pull/101): Set bundle options before check via bundle config - [@spajic](https://github.com/spajic)
Generated by :no_entry_sign: Danger
@mattbrictson May be it would be better to combine 5 config commands into 1? What do you think?
Closing in favor of #122
Hello, @mattbrictson !
This PR is advances idea, discussed in #97
Here I take two more options into account:
bundle_frozen
andbundle_disable_shared_gems
97 still has problem I'm trying to solve here, setting 3 options is happened to be not enough.
Now I set 5 bundle config options before
bundle check
:Code from this PR is battle-tested, we already use it in production.
Though we are adding 5 more commands, we still have order-of-magnitude win.
bundle
command may take more than 25 seconds to fetch metadata.5
bundle config
commands take about 1,5 seconds for us in deploy to 3 app-servers with 50ms ping.With faster ping 5
bundle config
will take even less time.