Don't override SSHKit.config.command_map

[leafac]

SSHKit's documentation says it's not wise to override it:

One can also override the command map completely, this may not be wise, but it would be possible, for example:

SSHKit.config.command_map = Hash.new do |hash, command| hash[command] = "/usr/local/rbenv/shims/#{command}" end

[leehambley]

Don't take my documentation too literally, it's a warning for people just getting to grips with the lib. But cool PR anyway.

On Thursday, October 17, 2013, Leandro Facchinetti wrote:

SSHKit's documentationhttps://github.com/leehambley/sshkit/blob/4c0694a96f445f27209cc56b576cd998c6e4b658/README.md#the-command-mapsays it's not wise to override it:

One can also override the command map completely, this may not be wise, but it would be possible, for example:

SSHKit.config.command_map = Hash.new do |hash, command| hash[command] = "/usr/local/rbenv/shims/#{command}" end

---

You can merge this Pull Request by running

git pull https://github.com/leafac/chruby dont-overwrite-command_map

Or view, comment on, or merge it at:

https://github.com/capistrano/chruby/pull/1 Commit Summary

• Don't override SSHKit.config.command_map

File Changes

• M lib/capistrano/tasks/chruby.rakehttps://github.com/capistrano/chruby/pull/1/files#diff-0(28)

Patch Links:

• https://github.com/capistrano/chruby/pull/1.patch
• https://github.com/capistrano/chruby/pull/1.diff

Lee Hambley

http://lee.hambley.name/ +49 (0) 170 298 5667

[leafac]

This is an issue already, because importing capistrano-chruby makes regular commands run without /usr/bin/env, which is the default behavior in SSHKit.

But cool PR anyway.

Thanks :smile:

[kirs]

Thanks! Could you do the same trick with capistrano-rbenv?

[leafac]

Thanks for merging, @kirs.

Sure thing, I can do that. I'll get to it soon.

[leafac]

A comment by @kirs in rbenv/pull#12 made me realize it was possible to declare prefix only once in the loop. So I applied the change here in capistrano/chruby as well.