capistrano / composer

Capistrano extension for Composer tasks
MIT License
183 stars 48 forks source link

Support composer.phar version specify #14

Closed nishigori closed 10 years ago

nishigori commented 10 years ago

Composer latest can update to a specific release by running the self-update. (& getcomposer's install)

Hope to support that :)

References

peterjmit commented 10 years ago

Hi @nishigori sorry for the delay in responding I think this is a good addition. I will give @swalkinshaw a day or two to comment before merging.

swalkinshaw commented 10 years ago

My fault too. Saw this a while ago then forgot about it. It's fine overall but I'd rather avoid setting composer_version by default to an empty string. See my comments about how to work around that.

nishigori commented 10 years ago

@peterjmit @swalkinshaw Thanks response & commented.

It was changed default value of composer_version and I'm following the idea . How about this?

swalkinshaw commented 10 years ago

@nishigori looks good, thanks for the quick work! Just one more minor thing that I commented on.

swalkinshaw commented 10 years ago

@peterjmit still look good to you?

peterjmit commented 10 years ago

@nishigori if you could fix the errors, and squash the commits into one, then I think we can merge!

nishigori commented 10 years ago

@swalkinshaw Thanks your many comment :) I was just commiting 860e941 that it's fixed.

@peterjmit It was squashed commits into one :smile: If you accept, please merge it.

executed to this PR

$ bundle exec cap production composer:self_update
DEBUG [d586b87d] Running /usr/bin/env if test ! -d /var/tmp/current; then echo "Directory does not exist '/var/tmp/current'" 1>&2; false; fi on 127.0.0.1
DEBUG [d586b87d] Command: if test ! -d /var/tmp/current; then echo "Directory does not exist '/var/tmp/current'" 1>&2; false; fi
DEBUG [d586b87d] Finished in 0.043 seconds with exit status 0 (successful).
 INFO [f43111d8] Running /var/tmp/shared/composer.phar selfupdate 1.0.0-alpha8 on 127.0.0.1
DEBUG [f43111d8] Command: cd /var/tmp/current && /var/tmp/shared/composer.phar selfupdate 1.0.0-alpha8
DEBUG [f43111d8]    Updating to version 1.0.0-alpha8.
DEBUG [f43111d8]        Downloading: connection...
DEBUG [f43111d8]
DEBUG [f43111d8]        Downloading: 0%
...
DEBUG [f43111d8]        Downloading: 100%
DEBUG [f43111d8]
DEBUG [f43111d8]    Use composer self-update --rollback to return to version eb3384445b657d0b2ab92d09060157dafd33abb5
 INFO [f43111d8] Finished in 21.075 seconds with exit status 0 (successful).
$ bundle exec cap production composer:install_executable
DEBUG [38da25db] Running /usr/bin/env if test ! -d /var/tmp/shared; then echo "Directory does not exist '/var/tmp/shared'" 1>&2; false; fi on 127.0.0.1
DEBUG [38da25db] Command: if test ! -d /var/tmp/shared; then echo "Directory does not exist '/var/tmp/shared'" 1>&2; false; fi
DEBUG [38da25db] Finished in 0.042 seconds with exit status 0 (successful).
DEBUG [d7a503b0] Running /usr/bin/env [ -e composer.phar ] on 127.0.0.1
DEBUG [d7a503b0] Command: cd /var/tmp/shared && /usr/bin/env [ -e composer.phar ]
DEBUG [d7a503b0] Finished in 0.011 seconds with exit status 1 (failed).
 INFO [276a3461] Running /usr/bin/env curl -s https://getcomposer.org/installer | php -- --version=1.0.0-alpha8 on 127.0.0.1
DEBUG [276a3461] Command: cd /var/tmp/shared && /usr/bin/env curl -s https://getcomposer.org/installer | php -- --version=1.0.0-alpha8
DEBUG [276a3461]    Downloading...
DEBUG [276a3461]
DEBUG [276a3461]    Composer successfully installed to: /var/tmp/shared/composer.phar
DEBUG [276a3461]
DEBUG [276a3461]    Use it: php composer.phar
 INFO [276a3461] Finished in 21.205 seconds with exit status 0 (successful).

Of course It's no problem If you don't add option of :composer_version

peterjmit commented 10 years ago

:+1:

swalkinshaw commented 10 years ago

@nishigori thanks, great work :)

nishigori commented 10 years ago

Thanks for being with me for a long time :)

ARIGATO !! ARIGATO :rainbow: