Make run command working

[ismailasci]

The install_executable task installs composer inside the shared folder within the name of composer.phar which is a php packages without execute rights. So when run command runs it ends up with an error like composer: command not found. The problems are:

• composer.phar is the file name not composer.
• since the file is not executable you can't execute it

This PR solves the file name and makes composer executed through php.

[swalkinshaw]

Not sure about this since it would also break for anyone not using install_executable. Just having the command as composer is the simplest default since we can't make it for everyone out of the box.

Also, this is actually documented in the README https://github.com/capistrano/composer#installing-composer-as-part-of-a-deployment

Keeping the command as just composer also makes it easier to override it with command_map. The way you have it right now, you'd have to override php in command_map which you really don't want to do.

[ismailasci]

Argh I missed that part in the documentation! I first looked for a parameter to change composer path/name but could not find and ended up overriding the task.

Even though install_executable won't make composer.phar executable and running it without php will end up with an error or am I missing something?

[swalkinshaw]

Maybe not. We can update the docs to add php:

SSHKit.config.command_map[:composer] = "php #{shared_path.join("composer.phar")}"

[peterjmit]

See my linked documentation update commit - I think this can be closed now?

[ismailasci]

Yes, this should be ok now. Thanks!