search

capistrano / rails

Official Ruby on Rails specific tasks for Capistrano
http://www.capistranorb.com/
MIT License
867 stars 270 forks source link

Allow overriding migration servers #168

Closed aliismayilov closed 8 years ago

aliismayilov commented 8 years ago

This would enable users to run migrations on multiple servers. I've seen this being discussed at https://github.com/capistrano/capistrano/issues/1449.

Unlike https://github.com/capistrano/rails/pull/127, it doesn't change the existing functionality. And unlike https://github.com/capistrano/rails/pull/126 it actually works.

In our case, we would be able to override the migration_servers value with set :migration_servers, -> { release_roles(fetch(:migration_role)) }

mattbrictson commented 8 years ago

Excellent work! :sparkles: Can you add a mention of this new feature under the "master" heading of the CHANGELOG?

aliismayilov commented 8 years ago

Thanks for a quick feedback! I've amended CHANGELOG changes.

mattbrictson commented 8 years ago

Thanks for the PR! :bow:

Bertg commented 8 years ago

Can we have a 1.1.7 release for this please? Would be very appreciated :)

mattbrictson commented 8 years ago

I would be happy to, but I don't have gem publishing rights. For that you will need to get the attention of @kirs.

Bertg commented 8 years ago

@kirs Can we have a 1.1.7 release for this please? Would be very appreciated :)

kirs commented 8 years ago

Pushed 1.1.7. Thank you for the PR!

I tried adding @mattbrictson as an owner but his email on Github is hidden and all it provides is mattbrictson@users.noreply.github.com.

gregblass commented 6 years ago

This just worked like a charm. Thanks to all involved!