search

capistrano / rails

Official Ruby on Rails specific tasks for Capistrano
http://www.capistranorb.com/
MIT License
867 stars 270 forks source link

Use migration command to construct log message #254

Closed harimohanraj89 closed 2 years ago

harimohanraj89 commented 2 years ago

Summary

This is a follow-up to #242 , which introduced the migration_command configuration option. It's a great option that we're keen to use (as we use data migrations in our project). When upgrading, I noticed that the informational log message still says "Running rake db:migrate", even if a different migration command is provided.

This PR updates the log message to also dynamically print a message based on the provided migration command.

Short checklist

Other Information

☝️ I'm not sure where to make the CHANGELOG entry. If you could point me in the right direction, I can add a note about this change to the appropriate CHANGELOG, thanks!

mattbrictson commented 2 years ago

Looks good, thanks for catching this!

No need to modify the CHANGELOG, the release notes are now generated automatically from the PR titles. I'll make sure the PR checklist is updated to remove the CHANGELOG from the checklist.

harimohanraj89 commented 2 years ago

Sounds great, thank you!