search

capistrano / rails

Official Ruby on Rails specific tasks for Capistrano
http://www.capistranorb.com/
MIT License
867 stars 270 forks source link

`cap doctor` erroneously reports that `:keep_assets` is an unrecognized setting #262

Closed mattbrictson closed 1 year ago

mattbrictson commented 1 year ago

As identified by @JasonPoll in https://github.com/capistrano/rails/issues/251#issuecomment-1613836805

JasonPoll commented 1 year ago

@mattbrictson are you going to work on this? If correcting this is simply a matter of setting :keep_assets in lib/capistrano/tasks/assets.rake, I can put up a quick pull request.

mattbrictson commented 1 year ago

@JasonPoll yes, if you want to put a PR, I'd appreciate it! I think you're right: :keep_assets needs a default value (nil should work).

JasonPoll commented 1 year ago

Will do. I was about to suggest having :keep_assets default to the value of :keep_releases, but having thought more on it, I agree - nil is the appropriate default, and it aligns with what is currently noted as the default in the README.md.

mattbrictson commented 1 year ago

Closed via #263