search

capistrano / rbenv

Idiomatic rbenv support for Capistrano 3.x
MIT License
203 stars 60 forks source link

add support sshkit >= 1.9.0 #65

Closed batizhevsky closed 8 years ago

batizhevsky commented 8 years ago

Due to sshkit 1.9 requires explicitly include it, rbenv does not work with new versions.

mattbrictson commented 8 years ago

I believe this is an issue only if you try to use an old version of Capistrano with SSHKit >= 1.9.0. Refer to this issue for details and a general workaround: https://github.com/capistrano/sshkit/issues/338

IMO this is not something specific to capistrano-rbenv that should be addressed here.

batizhevsky commented 8 years ago

IMO this is not something specific to capistrano-rbenv that should be addressed here.

Why not? capistrano-rbenv uses sshkit dsl which required explicitly include itself. There some limits on higher version of capistrano, for example the drop of legacy Rubies support.

mattbrictson commented 8 years ago

This is not a problem unique to capistrano-rbenv, which is why I think it is incorrect to address it here. By your logic, every Capistrano plugin would need to be changed (since all Capistrano plugins use SSHKit). The workarounds are:

  1. Use an older version of SSHKit (you already seem to be OK with using an old version of Capistrano).
  2. Include the SSHKit DSL in your Capfile, as I already mentioned: https://github.com/capistrano/sshkit/issues/338