search

capistrano / rbenv

Idiomatic rbenv support for Capistrano 3.x
MIT License
203 stars 60 forks source link

Make rbenv_ruby optional #67

Closed spikeheap closed 7 years ago

spikeheap commented 7 years ago

This PR addresses #61 and resolves the issue where the Ruby version changes between the current and new releases.

By removing the requirement for :rbenv_ruby, we can delegate the decision to the remote host's rbenv, which will follow these steps to choose a version. This mitigates the above problem by using the 'old' Ruby version to run commands on current, and the 'new' Ruby version on the release in progress.

mattbrictson commented 7 years ago

This seems reasonable to me, but I don't use capistrano-rbenv and therefore don't feel comfortable merging without further review. Can anyone else provide feedback on this PR?

spikeheap commented 7 years ago

It would be great to see this merged. Is there anything I could do to increase it's chances of getting merged?

mattbrictson commented 7 years ago

@kirs @leehambley Any strong opinions on this one?

doits commented 7 years ago

+1 for me - I'd like the app server to decide which ruby version to use, and when the app server upgrades its ruby version, why do I have to update every deploy config of every single app? So having this optional - forcing a ruby version if I really want/need to, otherwise simply using the global ruby version - seems to be a good way to make everybody happy.

mattbrictson commented 7 years ago

OK, I'll merge this in. Thanks!