Closed creitve closed 7 years ago
Thanks for the PR! This project lacks automated tests, which makes reviewing and approving PRs somewhat difficult. Please make sure that your contribution has not broken backwards compatibility or introduced any risky changes.
Generated by :no_entry_sign: Danger
Also please tell me if you do want to see the changelog updated with this^
Hi, thanks for creating this PR! Yes, I think a CHANGELOG entry is warranted here.
Also, I think the warning could be improved even further by including the host name. The host is passed to every on
block, so you can do it like this:
# Notice the additional `host` argument
on release_roles(fetch(:rbenv_roles)) do |host|
# ...
warn "rbenv: #{rbenv_ruby} is not installed or not found in #{fetch(:rbenv_ruby_dir)} on #{host}"
Thanks for your help! I hope that this will suffice.
Looks good, thanks! 🙇
For the Issue #73