search

capistrano / rvm

MIT License
140 stars 47 forks source link

Confusion with `gem 'capistrano-rvm'` (different gem ?) #11

Closed petervandenabeele closed 11 years ago

petervandenabeele commented 11 years ago

Hi, /cc @mpapis /cc @softr8

I may be confused, but these are my findings, trying to use this code with Capistrano v3.

Based on the require 'capistrano/rvm' in

https://github.com/capistrano/capistrano/blob/master/lib/capistrano/templates/Capfile#L18

and the link to documentation in

https://github.com/capistrano/capistrano/blob/master/lib/capistrano/templates/Capfile#L11

and the gem.name of this project being 'capistrano-rvm':

https://github.com/capistrano/rvm/blob/master/capistrano-rvm.gemspec#L6

I went on to add to my Gemfile

gem 'capistrano-rvm'

However, it seems like that is a completely different gem, posted in July 2012 by Edwin Cruz ( @softr8 ):

http://rubygems.org/gems/capistrano-rvm

I presume, the source code for the 'capistrano-rvm' gem can be found here (I did not easily see that link on rubygems):

https://github.com/softr8/capistrano-rvm

The result of using the naive inclusion of the 'capistrano-rvm' gem is the predictable error:

cannot load such file -- capistrano/rvm

If there is no way to merge the 2 code bases, maybe this code (here) needs to adopt another gem.name and publish a gem under that name?

For now, what worked is to use the link to this code on github (of which I made a fork to be sure and with a more descriptive name).

  gem 'capistrano-rvm', github: "petervandenabeele/capistrano_rvm" # Clone a known working version

Maybe this code here could use the (somewhat ugly) github project name and gem.name of capistrano_rvm . One advantage would be that github clones would automatically inherit a name that is more different from the real rvm project and the project name and gem name would be in line.

Probably there are better alternatives, I was just a bit confused by this and trying to propose a solution. Better solutions are probably possible :-)

Thanks,

@petervandenabeele

ayrton commented 11 years ago

I believe this is the same 'issue' as with https://github.com/capistrano/rbenv, I simply used the github: syntax as stated in the readme.

mpapis commented 11 years ago

assuming the gem name is taken I would advise to just pick another one, or claim the one taken i it has no downloads, github: is not the best solution, not everybody wants to use bundler

leehambley commented 11 years ago

I'd propose to avoid namespace collisions we start to transition the plugin gems to be called "capistrano-plugin-rbenv" - but it's just an ugly workaround.

leehambley commented 11 years ago

Perhaps better to address this now than before the naming propagates as-is.

petervandenabeele commented 11 years ago

Hi Edwin ( @softr8 ),

Any ideas on this ?

@petervandenabeele

softr8 commented 11 years ago

oh no!

Is there any way to transfer the ownership? I'm big fan/user of capistrano and whatever is better for the project I'm wiling to accept it.

petervandenabeele commented 11 years ago

Thanks :-)

mpapis commented 11 years ago

@softr8 gem help owner

softr8 commented 11 years ago

I've added @kirs as owner

leehambley commented 11 years ago

Thanks for the epic teamwork here gents!

Lee Hambley

http://lee.hambley.name/ +49 (0) 170 298 5667

On 14 October 2013 23:02, Edwin Cruz notifications@github.com wrote:

I've added @kirs https://github.com/kirs as owner

— Reply to this email directly or view it on GitHubhttps://github.com/capistrano/rvm/issues/11#issuecomment-26288494 .

kirs commented 11 years ago

Thanks! I've pushed it on rubygems and mentioned it in README.