Remove SSHKit dependency

[Kriechi]

capistrano-rvm blocks the usage of a newer SSHKit gem version, because of the over restrictive version selector.

I think we should remove the SSHKit dependency completely.

[mpapis]

I would change it to >= as it was required for the prefix on command map

[Kriechi]

Good catch. Thanks. I didn't think about the command map. Of course, then i would suggest using >=1.2.

[kirs]

We have SSHKit dependency because it's used inside the capistrano-rbenv code: https://github.com/capistrano/rvm/blob/master/lib/capistrano/tasks/rvm.rake#L35

It's important to have >=1.2 because we need exact features from this version.

capistrano-rvm blocks the usage of a newer SSHKit gem version, because of the over restrictive version selector. that means we just have to use flexible dependency, right?

[kirs]

Fixed: https://github.com/capistrano/rvm/blob/master/capistrano-rvm.gemspec

[mpapis]

I still see:

gem.add_dependency 'sshkit', '~> 1.2'

was it supposed to be >=?

[kirs]

It wasn't, because >= would allow to use 2.x that may have breaking API changes.

[mpapis]

then I'm confused, 1.2 introduced that breaking changes, it should be pushed to 2.0 then ... just saying