search

capistrano / sshkit

A toolkit for deploying code and assets to servers in a repeatable, testable, reliable way.
MIT License
1.13k stars 253 forks source link

Fix test by `require 'set'` #508

Closed colorbox closed 1 year ago

colorbox commented 1 year ago

There are some tests fail with messages below.

SSHKit::TestConfiguration
  test_nil_deprecation_output                                    ERROR (0.00s)
Minitest::UnexpectedError:         NameError: uninitialized constant SSHKit::DeprecationLogger::Set
        Did you mean?  Net
            /Users/colorbox/.ghq/github.com/capistrano/sshkit/lib/sshkit/deprecation_logger.rb:5:in `initialize'
            /Users/colorbox/.ghq/github.com/capistrano/sshkit/lib/sshkit/configuration.rb:21:in `new'
            /Users/colorbox/.ghq/github.com/capistrano/sshkit/lib/sshkit/configuration.rb:21:in `deprecation_output='
            /Users/colorbox/.ghq/github.com/capistrano/sshkit/test/unit/test_configuration.rb:25:in `test_nil_deprecation_output'

This PR add require 'set' to avoid raise NameError.

mattbrictson commented 1 year ago

Perfect, thanks for the fix!