capistrano / sshkit

A toolkit for deploying code and assets to servers in a repeatable, testable, reliable way.
MIT License
1.15k stars 253 forks source link

Replace Vagrant with Docker Compose for running functional tests #539

Closed mattbrictson closed 3 months ago

mattbrictson commented 3 months ago

Our functional tests had been failing in CI for quite some time. They relied on VirtualBox (managed by Vagrant), which no longer works reliably on the standard GitHub Actions runners. We disabled functional tests in CI due to this problem (see #523).

This PR fixes the functional tests by swapping out Vagrant for Docker Compose, following the example of https://github.com/capistrano/capistrano/pull/2159.

Docker Compose works fine with GitHub Actions, so I also reenabled functional tests in CI, borrowing from #522.

And they work now!

Screenshot 2024-06-14 at 5 24 06 PM