search

capistrano / symfony

Capistrano tasks for deploying the Symfony standard edition
MIT License
354 stars 65 forks source link

Add role filtering #82

Closed sgrodzicki closed 6 years ago

sgrodzicki commented 7 years ago

Similar to Capistrano::Composer we need a possibility to run Symfony tasks based on roles.

sgrodzicki commented 7 years ago

@peterjmit this pull request aims to be backward compatible.

sgrodzicki commented 7 years ago

Ping @peterjmit

Nyholm commented 6 years ago

Hey. Sorry for the delay. I just got write access to this library. Could you rebase you PR on master?

Nyholm commented 6 years ago

Related to #67

sgrodzicki commented 6 years ago

@Nyholm done

sgrodzicki commented 6 years ago

@Nyholm you're right. It was inconsistent.

Nyholm commented 6 years ago

Also, looking at: https://github.com/capistrano/symfony/pull/67/files

He/She does something like: 

roles(fetch(:symfony_deploy_roles))

Could you tell my the difference?

sgrodzicki commented 6 years ago

@Nyholm AFAIK release_roles() and roles() work the same in that case so I just used the first one.

Nyholm commented 6 years ago

Okey. Thank you for clarifying that. And thanks for your work.