capistrano / symfony

Capistrano tasks for deploying the Symfony standard edition
MIT License
354 stars 65 forks source link

symfony_deploy_roles in place of symfony_roles #90

Open mocrates opened 6 years ago

mocrates commented 6 years ago

Hello,

I don't know if i do somethings wrong but:

When i have in my deploy.rb :

   # Role filtering
   set :symfony_roles, :web

It's don't execute symfony task as controllers_to_clear

But when I put :

set :symfony_deploy_roles, :web

Its work.

In symfony.rake it 's always fetch this var:

 on release_roles(fetch(:symfony_deploy_roles)) do
      within symfony_web_path do
        execute :rm, "-f", *fetch(:controllers_to_clear)
      end
    end

Whereas it's store in other var:

role = args[:role] || fetch(:symfony_roles)

I am not an expert in ruby that's why i not PR it and i am not sure about it

Nyholm commented 6 years ago

Hm, I think it is the correct behavior. Im not sure though..

nesl247 commented 6 years ago

Looks like this was introduced with #82.