Closed AdrianoFerrari closed 6 years ago
Thanks for the detailed feedback. Making those changes now and will push soon.
(PS: I did allow edits from maintainers, but it might still require pulling from my fork and making changes locally)
Ok, @YetAnotherMinion
Made the changes, and checked that --docs
and tests/Main.elm
both work.
Let me know if there's anything else.
PS: elm-make src/Octicons.elm
yields this error, but does so even on master branch:
Uncaught TypeError: Elm.Octicons.fullscreen is not a function
Package version 2.2.0 published. Thanks again for the fast turnaround.
Thank you for the fast turnaround as well :+1:
Thank you for your contribution, if I could figure out how to edit your PR from the web UI I would make review changes myself and then merge. Maybe there is a checkbox you can hit to allow maintainers to edit your PR?