search

capitalone / DataProfiler

What's in your data? Extract schema, statistics and entities from datasets
https://capitalone.github.io/DataProfiler
Apache License 2.0
1.43k stars 162 forks source link

Delay transforming priority_order into ndarray #1045

Closed junholee6a closed 1 year ago

junholee6a commented 1 year ago

Issue: https://github.com/capitalone/DataProfiler/issues/722

In the changed code, we had a mypy error because numpy ndarrays are not compatible with random.Random.shuffle() (expected argument type is MutableSequence[Any])

We fix this by first instantiating priority_order as a list, then shuffling it, then creating an ndarray from it afterwards.

junholee6a commented 1 year ago

This is a remake of PR https://github.com/capitalone/DataProfiler/pull/969 after branches were rebuilt

ksneab7 commented 1 year ago

Please update when able :)

taylorfturner commented 1 year ago

Thanks @junholee6a!