Closed thebadcoder96 closed 8 months ago
I am having issues with validating. I changed the .yml to my branch but I am getting an error fatal: No names found, cannot describe anything.
Quick googling leads me to believe that this usually means no tags are found. I am a bit confused about how tags work to understand why this is happening.
I read that this might have something to do with the git clone being shallow. Possible solution could be to add this to the .yml file before the git describe --tags line.
- run: git fetch --prune --unshallow
I have no idea what that means. Please advise
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: thebadcoder96
:x: actions-user
You have signed the CLA already but the status is still pending? Let us recheck it.
I updated the .yml file to fix the issue I mentioned earlier. And it passed the validation; the github action-user
committed to change the readme file to my branches tag.
Please review. (Sorry for so many commits I was testing on my branch)
The current logic I have used is pulling the latest tag from the latest commit across all branches which is not what we want. We want it to be the latest tag from the latest commit within one branch. I have updated the .yml for that and also tested it on my forked dev
and dynamiclink
branches. I also have updated the GitHub actions commit username to my email so it is CLA complaint.
I am closing this PR and will open a new one with the updated changes so it is CLA complaint.
Related to Issue #972
I have changed the hyperlink URL in the readme file and also added a new workflow that will update the link to the live version of the package.