refactor: Upgrade the models to use keras 3.0

capitalone / DataProfiler

What's in your data? Extract schema, statistics and entities from datasets

https://capitalone.github.io/DataProfiler

Apache License 2.0

1.41k stars 157 forks source link

Closed JGSweets closed 2 months ago

JGSweets commented 3 months ago

This pr:

refactors the following models to use keras 3.0
- structured_model
- unstructured_model
- CharLoadTFModel
Fixes a bug in loading a trainable model from library
updates requirements for keras 3.0
fixes manifest to not include pycache files

JGSweets commented 3 months ago

Added a commit to drop support for Python 3.8 since tensorflow >= 2.16.0 does not exist for that version.

taylorfturner commented 3 months ago

Seeing issues with test suite on M1 & intel chip on macOS. Runs great on linux / GHA, though

taylorfturner commented 3 months ago

Noticing this in the keras 2 -> 3 conversion directions too. Haven't tested fully yet, but could be at issue

lettergram commented 2 months ago

Hello, any way we can get this merged?

taylorfturner commented 2 months ago

Hello, any way we can get this merged?

Hey @lettergram, yes.

Needs a rebase / resolution of two conflicts now
I'll be doing a release prior to June 14th. Trying to validate this on my end because the proposed changes hang locally with no error. Would like to see this run locally

Thanks!

JGSweets commented 2 months ago

@taylorfturner @lettergram rebase complete!