Open faizanfahmed opened 5 years ago
@faizanfahmed thanks for pr! If you haven't already I would recommend creating an example file so that you could try out creating and terminating your particle. It will help us review as well. We have all aws examples in this folder https://github.com/capitalone/Particle-Cloud-Framework/blob/master/examples/particle/aws/ if you want to take a look
I'll definitely add an example and start running through the lifecycle. Thanks!
Definitely need to add unit test as well. Looks like Moto does support Batch. But I'm not sure how complete it is. https://github.com/spulec/moto/tree/7f0b1d679591a6b69f5d620b2b0ff0a311ed7582/moto/batch
Otherwise, we use Placebo as well. @anovis added a tool to help making generating Placebo test. https://github.com/capitalone/Particle-Cloud-Framework/pull/114
looks like small merge conflict. once you fix it looks ready to merge. thanks for pr!
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Looking for feedback on batch job particle and batch job definition particle. Need to add testing, potentially introduce error handling or retry logic, and improve sync_state/update functions. Unsure on how to handle is_state_equivalent function.